<html>
<head><meta charset="utf-8"><title>contributing questions · project-thir-unsafeck · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/index.html">project-thir-unsafeck</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html">contributing questions</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="229601368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229601368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> danii <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229601368">(Mar 10 2021 at 04:22)</a>:</h4>
<p>hello, Zulip!<br>
i'm interested in helping contribute to this project, will this be too complicated for a mere mortal like me? (i've only touched the standard library tests, once)</p>



<a name="229633110"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229633110" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229633110">(Mar 10 2021 at 10:19)</a>:</h4>
<p>I think the biggest problem is conflicts with <span class="user-mention" data-user-id="255061">@Léo Lanteri Thauvin</span> 's work. There were a few ideas spawned off in the eager THIR PR that I think can be pursued in parallel. One thing that could be looked into as a separate project would be the deduplication of pattern building. We currently build patterns twice, but there's no reason to actually do so, and I don't know what's the status on that. So the first step would be to analyze that</p>



<a name="229633188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229633188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229633188">(Mar 10 2021 at 10:19)</a>:</h4>
<p>even so, please coordinate with <span class="user-mention" data-user-id="255061">@Léo Lanteri Thauvin</span> on anything before starting to work on  something, as I don't know what they already have in the pipeline</p>



<a name="229634945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229634945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229634945">(Mar 10 2021 at 10:34)</a>:</h4>
<p>I've opened a few issues in the <a href="https://github.com/rust-lang/project-thir-unsafeck">project-thir-unsafeck</a> which can be used to assign work</p>



<a name="229635030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229635030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229635030">(Mar 10 2021 at 10:35)</a>:</h4>
<p>But everything is blocked on <a href="https://github.com/rust-lang/rust/issues/82495">#82495</a> right now</p>



<a name="229635177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/229635177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#229635177">(Mar 10 2021 at 10:36)</a>:</h4>
<p>Feel free to take a look at the open issues and see if you can find something you're interested in working on</p>



<a name="230272581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/contributing%20questions/near/230272581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/contributing.20questions.html#230272581">(Mar 14 2021 at 22:07)</a>:</h4>
<p><span class="user-mention" data-user-id="340105">@danii</span> if you're still interested in contributing, here are a few notes:</p>
<ul>
<li>if you've never worked on the compiler before, I think you could start with <a href="https://github.com/rust-lang/project-thir-unsafeck/issues/6">project-thir-unsafeck#6</a>, which is about updating and improving the documentation of the compiler. This should give you some context to then be able to write code</li>
<li>I've just opened <a href="https://github.com/rust-lang/rust/issues/83129">#83129</a>, which, if merged, will make it possible to implement the THIR unsafety checker as incremental steps: just take a type of unsafe operation (I like to refer to the list <a href="https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/mir/query.rs.html#55-119">here</a>), add it to the unsafeck and file a PR</li>
<li>as <span class="user-mention silent" data-user-id="124288">oli</span> was saying, there is also <a href="https://github.com/rust-lang/project-thir-unsafeck/issues/4">project-thir-unsafeck#4</a> which seems more complex to me, but I haven't yet completely grasped how exhaustiveness checking works. I'd like to maybe extract it to its own module as a first step</li>
</ul>
<p>If any of this is unclear feel free to ping me :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>